Remove setting of `CreateNoWindow` to reduce overhead

[ian-g-holm-intel]

I've observed a 30-40ms overhead added to the execution time of any process when you set ProcessStartInfo.CreateNoWindow to anything, true or false. I'm not sure why exactly this is, but you can see the difference in the benchmarks really easily. CliWrap sets CreateNoWindow = true and UseShellExecute = false. But as far as I can tell, UseShellExecute = false is the default and CreateNoWindow doesn't work unless UseShellExecute = true. So removing those two settings from the ProcessStartInfo is functionally equivalent to the way they are currently, but it allows processes to run without the 30ms overhead.

[ian-g-holm-intel]

I ran a benchmark executing "cmd.exe /c echo this is a test" with CreateNoWindow set to true vs unset. CreateNoWindow = true CreateNoWindow unset

[ian-g-holm-intel]

This proposed fix will check if the current application has a console or not. If it does not, it will set ProcessStartInfo.CreateNoWindow = true. If it does have a console, CreateNoWindow will not be set, avoiding the added overhead of setting it.

[Tyrrrz]

@Retik okay, just to make sure, you tested all previously scenarios with this and it works correctly, right? desktop/console/batch file, etc

[what-the-diff[bot]]

• The diff above is a change to the CliWrap/Command.cs file and adds a new file called NativeMethods.cs
• In Command, we are checking if there is no console window on Windows platforms before setting CreateNoWindow = true in ProcessStartInfo
• We added an external method GetConsoleWindow() from kernel32 that returns IntPtr (pointer) for use in our check of whether or not there's a console window open