Tyrrrz / DiscordChatExporter

Exports Discord chat logs to a file
MIT License
7.48k stars 682 forks source link

Progess in CLI scrolling down makes it impossible to track progress of some channels #1124

Closed CanePlayz closed 1 year ago

CanePlayz commented 1 year ago

Version

v2.40.4

Flavor

CLI (Command-Line Interface)

Platform

Windows

Export format

No response

Steps to reproduce

Use an export command with a high amount of channels and a parallel limit > 1

Details

Once some channels are finished, new channels and their progress bars start appearing. After a fixed amount of new channels have appeared at the bottom, the ones at the top start to disappear, sometimes making it impossible to track progress of channels which are still being downloaded.

Checklist

CanePlayz commented 9 months ago

@Tyrrrz What about adding a little "x/y" above or below the channels currently being exported? Like

Channels: 7/56
Threads: 0/14

Alles / ranandenrind  ----------------------------------------  61%
Alles / bot-stuff     ----------------------------------------   7%
Alles / musicbot      ----------------------------------------  21%
Alles / mimimimeme    ----------------------------------------  57%
Alles / wm-?         ----------------------------------------  30%
Alles / wieb-??       ----------------------------------------  31%
Alles / ????-monkeeee ----------------------------------------  14%
Alles / stats-archiv  ----------------------------------------  23%

(btw don't ask me why the "wm" channel is not on the right column, it's probably some emoji character stuff messing around)

With fully exported channels disappearing, you can now see the channels that are being exported but makes it hard to see how much is already done. 😅

Note that unlike the commit done here, this would not have to be exclusive to parallel exports, but it could, since in not-parallel exports channels don't disappear anyways.

Tyrrrz commented 9 months ago

So what you're suggesting is hiding completed tasks for all kinds of exports, but also have a status at the top?

CanePlayz commented 9 months ago

I'm just suggesting adding the status bit at the top. That could be added for all exports, yeah, but also just for ones with parallel exporting, whatever one would prefer.

Hiding completed tasks for not parallel exports wasn't necessary because you just need to see the progress bar of the channel which just spawned at the very bottom, which you can surely do.

Tyrrrz commented 9 months ago

Hiding completed tasks for not parallel exports wasn't necessary because you just need to see the progress bar of the channel which just spawned at the very bottom, which you can surely do.

But then you won't see the status at the top. I also think that Spectre.Console doesn't allow to interactive components to be visible at the same time (in this case, the status text and the progress list)