Thread names get exported as `#deleted-channel` in mentions - Githubissues

Tyrrrz / DiscordChatExporter

Exports Discord chat logs to a file

MIT License

7.65k stars 699 forks source link

Thread names get exported as `#deleted-channel` in mentions #1261

Open ShadowJonathan opened 3 months ago

ShadowJonathan commented 3 months ago

Version

2.43.3

Flavor

CLI (Command-Line Interface)

Platform

Linux (Debian)

Export format

HTML

Steps to reproduce

Make a mention to a thread in a channel
Export that channel
Observe the mention being converted to #deleted-channel

Details

This piece of code is relevant;

https://github.com/Tyrrrz/DiscordChatExporter/blob/281e0f608ad0784bce1dc2d2cc7b76e419905ebd/DiscordChatExporter.Core/Exporting/HtmlMarkdownVisitor.cs#L284

It only looks for a name of the channel, not of a thread.

Even discord seems to struggle, not fetching a corresponding thread, only saying #unknown

Checklist

[X] I have looked through existing issues to make sure that this bug has not been reported before
[X] I have provided a descriptive title for this issue
[X] I have made sure that this bug is reproducible on the latest version of the application
[X] I have provided all the information needed to reproduce this bug as efficiently as possible
[ ] I have sponsored this project
[ ] I have not read any of the above and just checked all the boxes to submit the issue

Tyrrrz commented 3 months ago

The issue is that we don't preload all threads as we do with channels, so we can't resolve the mentions the same way:

https://github.com/Tyrrrz/DiscordChatExporter/blob/281e0f608ad0784bce1dc2d2cc7b76e419905ebd/DiscordChatExporter.Core/Exporting/ExportContext.cs#L34-L49

We should employ a strategy similar to members:

https://github.com/Tyrrrz/DiscordChatExporter/blob/281e0f608ad0784bce1dc2d2cc7b76e419905ebd/DiscordChatExporter.Core/Exporting/ExportContext.cs#L51-L86