search

Tyrrrz / LightBulb

Reduces eye strain by adjusting screen gamma based on the current time
MIT License
2.28k stars 141 forks source link

The new Win10 update to 1903 broke this app #100

Closed Win10pissesmeoff closed 5 years ago

Win10pissesmeoff commented 5 years ago

Never had any issues before but after this Windows 10 update to 1903 this app doesn't work at all anymore. Not sure if there is an setting to fix this but figured you'd want to know about it.

Edit- After doing a bit more searching I found a fix on this page https://answers.microsoft.com/en-us/windows/forum/all/windows-10-1903-may-update-breaks-night-light/75f21187-07ff-4c3d-b552-f390f205db67?auth=1

I had slightly different files other than what was listed but I found 2 by ctrl+F "windows.data.bluelightreduction" and deleted that one and "windows.data.bluelightreduction.settings"

I restarted and it seems to be working again. Will update if the problem persists.

dolevu commented 5 years ago

It worked for me after deleting the registry keys also

dolevu commented 5 years ago

In my case, the first restart, it works. Then it breaks after second restart, I have to delete the registry keys again

dolevu commented 5 years ago

After installing Cumulative Update for Windows 10 Version 1903 for x64-based Systems (KB4503293) The problem fixed.

scarystuff commented 5 years ago

I have the Cumulative Update for Windows 10 Version 1903 for x64-based Systems (KB4503293) and it's not fixed for me :-/

dolevu commented 5 years ago

@scarystuff my LightBulb and Windows Night Mode stopped working today. So the issue is windows update itself, the problem still persists

TacosAreYum commented 5 years ago

Broken on 1903 for me too.

Win10pissesmeoff commented 5 years ago

Not sure if anyone else is still having issues, but I had it not work once after a reset. I just deleted the 2 registry files again and it seems to be working as intended now after resetting multiple times. This is on the Cumulative Update for Windows 10 Version 1903 for x64-based Systems (KB4503293).

dolevu commented 5 years ago

@Win10pissesmeoff I deleted the registry keys, but after restarting, the problem comes back. Right now I only sleep the computer, not shutting down so I won't have to delete the registry keys again and again.

Win10pissesmeoff commented 5 years ago

The problem comes back for me if I shut down my PC but I usually just keep it on sleep so that's why it wasn't resetting for me. Not sure how to fix other than deleting the registry files after every shut down.

dolevu commented 5 years ago

Finally it's fixed https://support.microsoft.com/en-us/help/4501375/windows-10-update-kb4501375

broizter commented 5 years ago

Still not fixed after installing kb4501375 for me.

dolevu commented 5 years ago

I can confirm it's still working for me after many times restarting. Maybe you should try to delete the registry keys mentioned above @broizter?

SethBergen commented 5 years ago

Not working for me either on the latest cumulative update (KB4507453). Any deleted keys reappear on restart.

broizter commented 5 years ago

Enabling or disabling multi-monitor in Windows fixes the problem temporarily until next scheduled color shift.

Jefferderp commented 5 years ago

Enabling or disabling multi-monitor in Windows fixes the problem temporarily until next scheduled color shift.

I just tested, and this is true for me as well. Updating to the latest (KB4507453) made no difference, but Lightbulb immediately began working once I disconnected all but my primary monitor.

@Tyrrrz, it appears the issue with color temperature not changing is caused by multiple displays, ever since Windows 1903.

starsoccer commented 5 years ago

+1 same issue, disabling multi-monitor fixes it.

Tyrrrz commented 5 years ago

Looks like Windows broke something with this update. The fact that it affects only multi-monitor setup leads me to think they changed something related to how the GetDC native function works with null pointer (which used to mean "all monitors").

I'll try to figure out if there's a workaround as soon as I have some time.

MariusSp commented 5 years ago

Any news on this front?

Tyrrrz commented 5 years ago

Working on it. Making some large changes in #105 which should hopefully enable tackling this issue.

Dainius14 commented 5 years ago

~As of af48000a1fd29644f1a456fbd453c039ad1ecead seems to be working fine in Windows 10 build 18362.418~

Dainius14 commented 5 years ago

Unfortunately, does not work on multi-monitor setup. At least works when only single monitor is used. Previous version did not work for single or multi monitor setup.

Tyrrrz commented 5 years ago

@Dainius14 just to clarify, "does not work on multi-monitor setup" means that neither of the two monitors' gamma change? or does it mean only primary monitor is affected but the other monitors stay the same?

starsoccer commented 5 years ago

I think it means both, I briefly tested it a few days ago and couldnt notice any change

Dainius14 commented 5 years ago

None of the monitors work

On Mon, 11 Nov 2019, 17:57 starsoccer, notifications@github.com wrote:

I think it means both, I briefly tested it a few days ago and couldnt notice any change

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Tyrrrz/LightBulb/issues/100?email_source=notifications&email_token=ADUL5BR6JMM3IRJOKGK64I3QTF6IBA5CNFSM4HXF36MKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDXIIGQ#issuecomment-552502298, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADUL5BTFAZXMR3MSU75BNWLQTF6IBANCNFSM4HXF36MA .

Tyrrrz commented 5 years ago

Closed accidentally sorry. Please check out latest build. I've changed how the device context of the virtual screen is resolved, it might have fixed this issue.

starsoccer commented 5 years ago

@Tyrrrz For me this build doesnt even start. I click it and see nothing. I dont see it in the task bar, cant find it in task manager etc..

Tyrrrz commented 5 years ago

Hm. Did you download the installer or the portable version?

Dainius14 commented 5 years ago

Tried it now.

Does not work :( Nothing happens on multi-monitor setup

starsoccer commented 5 years ago

I used the portable version(not installer)

Tyrrrz commented 5 years ago

@Dainius14 try this one https://github.com/Tyrrrz/LightBulb/commit/9018e191f2c36c501566ad111c8ca64c3cc9d2e7/checks?check_suite_id=305727114 I've switched to a different approach for grabbing DC, hope it helps. Unfortunately I don't have a second monitor nor Win10 1903 to test.

Dainius14 commented 5 years ago

Great work! It's working!

Tyrrrz commented 5 years ago

Sweet :)

starsoccer commented 5 years ago

@Dainius14 Did you use the portable or installer? Portable for me is still not starting.

Tyrrrz commented 5 years ago

Fix is in master, build is here, please test this on both single monitor and multi-monitor setups. And if you have access to Win7, Win8, Win8.1, it would be nice to test on them too.

CC @mirh @NomDeMorte @aure2006 if you guys can help test the latest build.

@starsoccer Did you unpack all of the files to a separate directory? Does it say anything at all or just quietly does nothing? Do you remember which was the last build that worked?

Tyrrrz commented 5 years ago

Also, @starsoccer you might need to install .NET Core 3.0 runtime (installer sets it up automatically). https://dotnet.microsoft.com/download/thank-you/dotnet-runtime-3.0.0-windows-x64-installer https://dotnet.microsoft.com/download/thank-you/dotnet-runtime-3.0.0-windows-x64-desktop-runtime-installer

starsoccer commented 5 years ago

Giving it a try now, but I dont think thats the issue. Mainly because my other portable install, 1.6.4.1 starts fine. So unless this is a new requirement I dont think its related.

Tyrrrz commented 5 years ago

Yes, it's new in 2.0

starsoccer commented 5 years ago

Nice that worked, would be useful to have that as an error popup. Like if its not found to show an error saying both are needed

Tyrrrz commented 5 years ago

I will include a notice on release page when 2.0 is released

NomDeMorte commented 5 years ago

Seems to be working here, on both monitors - although I'm still on 1809 so I'm not sure if this is of any relevance.... at least, the change didn't break old versions ;)

spacecheese commented 5 years ago

I couldn't get this to work on 1903. I just updated to 1909 and it still doesn't seem to be working on either monitor. Windows night light doesn't seem to do anything either.

Tyrrrz commented 5 years ago

@spacecheese what interface are your monitors connected with? Does f.lux not work either?

spacecheese commented 5 years ago

@Tyrrrz my monitors are connected to a gtx 970, f.lux seems to work fine though I'll try an update my graphics drivers and see if that makes any difference.

ChrisLMerrill commented 5 years ago

I've also updated to 1909 today and there is no change in LightBulb functionality (or f.lux).

spacecheese commented 5 years ago

New drivers didn't seem to make any difference.

Tyrrrz commented 5 years ago

@spacecheese I mean, are you using DisplayLink dock connect by any chance?

spacecheese commented 5 years ago

@Tyrrrz not using anything like that. My monitors are directly connected to the graphics card outputs.

spacecheese commented 5 years ago

Appologies. I've resolved my issue- it seems that the display drivers that TeamViewer installs don't support gamma ramps so that SetDeviceGammaRamp was failing.

Tyrrrz commented 5 years ago

@spacecheese Hmm, that's weird, although nice that it was resolved. How does it work, TeamViewer just installs display drivers that replace your GPU's drivers? Or were you connected to another computer through TeamViewer and had LightBulb installed there?

spacecheese commented 5 years ago

Teamviewer has an optional monitor driver that replaces the Windows "Generic PnP" one so that you can draw pictures over the screen. Pretty annoying to track down.