search

Tyrrrz / LightBulb

Reduces eye strain by adjusting screen gamma based on the current time
MIT License
2.23k stars 141 forks source link

Use `screenRect.Left` and `screenRect.Top` when checking for fullscreen boundaries #267

Closed lamrongol closed 7 months ago

lamrongol commented 7 months ago

Related Issue is #16

Tyrrrz commented 7 months ago

Can you explain please how this is related to #16?

lamrongol commented 7 months ago

@Tyrrrz Multis screens exist and they don't stand in line, sub(second) window top and left is not zero, like following:

image

Tyrrrz commented 7 months ago

The thing is that screenRect is that for the screen where the window is displayed, so it's not dependent on other screens. I think it's still harmless to merge, but I don't think it will affect #16 in any way.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9f15a7a) 96.35% compared to head (0b40cab) 96.35%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #267 +/- ## ======================================= Coverage 96.35% 96.35% ======================================= Files 7 7 Lines 192 192 Branches 15 15 ======================================= Hits 185 185 Misses 6 6 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.