Dark mode - Githubissues

Tyrrrz / LightBulb

Reduces eye strain by adjusting screen gamma based on the current time

MIT License

2.23k stars 141 forks source link

Dark mode #299

Closed LilithSilver closed 4 months ago

LilithSilver commented 4 months ago

Closes #298.

Screenshots:

Notes:

Colors are up for debate, feel free to make tweaks.
This upgrades Avalonia.Material to 3.6; dark mode needs the toggle button rework to be legible.
All the controls switch to accent color-mode in dark mode, with a boolean resource at the application theme level. TextBox and Slider didn't have the accent color-mode built in for some reason, so I added some extra styling.

Question: Do we want/need to have a specific light/dark theme toggle? Currently, it follows the system theme.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.35%. Comparing base (0dd6505) to head (90ee7bb).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #299 +/- ## ======================================= Coverage 96.35% 96.35% ======================================= Files 7 7 Lines 192 192 Branches 15 15 ======================================= Hits 185 185 Misses 6 6 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Tyrrrz commented 4 months ago

Thanks for the PR.

Yes, I think there should be a switch in the advanced settings section (after "Start with Windows").

As for colors, I think the sundial brushes need to be adjusted to be darker in dark mode, as they create too much contrast right now.

Maybe lowering the opacity would serve as a universal solution?

Otherwise, it looks really nice :)

LilithSilver commented 4 months ago

Yes, I think there should be a switch in the advanced settings section (after "Start with Windows").

Will do.

As for colors, I think the sundial brushes need to be adjusted to be darker in dark mode, as they create too much contrast right now.

I already did some adjustment, they're much darker - I was having trouble going darker without them looking "muted" and losing their glowy feel. Could you maybe suggest some colors?

Tyrrrz commented 4 months ago

I already did some adjustment, they're much darker - I was having trouble going darker without them looking "muted" and losing their glowy feel. Could you maybe suggest some colors?

Could you share what it looks like now? Or is it the same as in the original post?

LilithSilver commented 4 months ago

Could you share what it looks like now? Or is it the same as in the original post?

Same as the original post. It looks OK on my end and on my phone, but colors tend to be different on different monitors.