Tyrrrz / LightBulb

Reduces eye strain by adjusting screen gamma based on the current time
MIT License
2.27k stars 141 forks source link

"This app can't run on your PC" #310

Closed Xeogin closed 5 months ago

Xeogin commented 5 months ago

Version

2.5.2

Platform

Windows 11

Steps to reproduce

Install application (I use winget) Try to launch it

Details

I was using version 2.4.12 without issue and just updated to the latest version and it no longer launches. I tried running as admin, running the compatibility troubleshooter, uninstalling then reinstalling, and the result is the same. The issue is also present with the 2.5.1 installer. Oddly the 2.4.12 installer somehow shows as version 2.5.1 when launched?

Checklist

MononeV commented 5 months ago

This is because the download url is directed to the arm64 version for all architectures. @Tyrrrz Since new architectures are introduced, there might be additional work need to be done on the winget side.

Tyrrrz commented 5 months ago

@Xeogin what platform are you on? The old versions did work on arm64/x64/x86 platforms through the same executable, but their auto-update didn't take the platform into account, so it would download x64 after the split.

@MononeV which download URL are you referring to?

MononeV commented 5 months ago

@MononeV which download URL are you referring to?

As refer to https://github.com/microsoft/winget-pkgs/blob/master/manifests/t/Tyrrrz/LightBulb/2.5.2/Tyrrrz.LightBulb.installer.yaml, the download link is https://github.com/Tyrrrz/LightBulb/releases/download/2.5.2/LightBulb-Installer.win-arm64.exe

Tyrrrz commented 5 months ago

@MononeV which download URL are you referring to?

As refer to microsoft/winget-pkgs@master/manifests/t/Tyrrrz/LightBulb/2.5.2/Tyrrrz.LightBulb.installer.yaml, the download link is 2.5.2 LightBulb-Installer.win-arm64.exe (download)

I see, yes, that's incorrect. I didn't notice you mentioned you were using winget to install/update.

The package manifest in the winget catalog is managed by the community, not by me personally. I will create an issue there and close this one.

Tyrrrz commented 5 months ago

https://github.com/microsoft/winget-pkgs/pull/155887

Tyrrrz commented 5 months ago

Should be fixed now