Tyrrrz / YoutubeDownloader

Downloads videos and playlists from YouTube
MIT License
8.71k stars 1.19k forks source link

Always stuck at 100% #384

Closed wangzhenjjcn closed 11 months ago

wangzhenjjcn commented 11 months ago

Version

v1.10.4

Platform

windows 11

Steps to reproduce

https://www.youtube.com/@yuansir

Details

download a list over 100 videos sometime always have more than 5 videos shows 100% for a long time it keeps 100%

Checklist

wangzhenjjcn commented 11 months ago

when download this https://www.youtube.com/@12KScenicRelaxation it canceled a lot liniks without click cancele btn and i have loged in with my account

Tyrrrz commented 11 months ago

If you open task manager, do you see any ffmpeg.exe processes?

Tyrrrz commented 11 months ago

Could not reproduce the issue

wangzhenjjcn commented 11 months ago

@Tyrrrz when stuck shows,cannot find ffmpeg.exe but I click cancel on items shows 100% it changes to done then start a new parallel in list so maybe the completion judgment mechanism of the program can be diversified

wangzhenjjcn commented 11 months ago

@Tyrrrz maybe can adding a timeout detection when reaching 100% or 99% progress to prevent stuttering and temporarily increasing the number of download threads that exceed the threshold

wangzhenjjcn commented 11 months ago

heres my gif screen record at 3fps GIF 2023-11-9 18-24-39

Tyrrrz commented 11 months ago

I think it just takes a while to complete the conversion process. The progress is reported directly from FFmpeg, unfortunately it can't get more precise than this.

wangzhenjjcn commented 11 months ago

@Tyrrrz i dont know it is monitor the pid of ffmpeg.exe or catch a return from the processor

maybe it has a err on cal whether it is completed or not, I think

and with the number of tasks increases, it is more common to encounter this stuck state, which will continue to be stuck at 100% of the maximum number of tasks without human intervention it realy shows on my computer