search

Tyrsis / SE-Community-Mod-API

Space Engineers Community Modding API
GNU Lesser General Public License v3.0
23 stars 11 forks source link

[EXPLOIT] Player's with priority real-time on their client process will lock it, and the server, up #49

Open Vl4dim1r opened 9 years ago

Vl4dim1r commented 9 years ago

One of my players found this out on accident. He was messing around with his process priority, to try getting an fps boost. When he changed it to "realtime", his machine completely froze, and everyone playing received a "No message received" until the player forced a shutdown and disconnected. It wasn't a complete crash, but all of my players had horrible pings afterwards, requiring a restart.

joshuataylor commented 9 years ago

Does this happen with other players?

Vl4dim1r commented 9 years ago

I managed to replicate the effect with other players, in more than one way. It seems the server is getting hung up on clients that are locked up/ not responding, and lasts until they unfreeze or force disconnect. On Jan 31, 2015 12:03 AM, "Josh Taylor" notifications@github.com wrote:

Does this happen with other players?

— Reply to this email directly or view it on GitHub https://github.com/Tyrsis/SE-Community-Mod-API/issues/49#issuecomment-72306304 .

dodexahedron commented 9 years ago

Does this happen with vanilla?

Vl4dim1r commented 9 years ago

Im actually not entirely sure, my ayer count hasnt dropped low enough for me to warrant shutting down the world. I'll test it when i perform some network maintenance later today, unless anyone else wants to attempt it. We tried various methods of locking the client up (spamming chrome, setting process priority high, general process slowing stuff) so it really isnt hard to replicate for anyone else that wants to take a crack at it On Jan 31, 2015 10:44 AM, "dodexahedron" notifications@github.com wrote:

Does this happen with vanilla?

— Reply to this email directly or view it on GitHub https://github.com/Tyrsis/SE-Community-Mod-API/issues/49#issuecomment-72325207 .

dodexahedron commented 9 years ago

I fired up a test world and was able to replicate the behavior with vanilla once, but not a second time. Can someone else verify this one?

Tyrsis commented 9 years ago

There is almost zero chance this is extender related. If this occurs, it would occur on vanilla also. But if someone can confirm it, I can forward the issue to keen.

Vl4dim1r commented 9 years ago

The [XTT] server group has replicated the issue on vanilla SEdedi. It gets worse with more players, as we had players come in one by one to our Testing Grounds, and open something that consumes their resources. The simulation speed/ping change is very noticeable between 5 players with free resources open to SE and with 2 players having free resources for SE and 3 with chrome/firefox (or process priority: realtime), and that is with us just flying around a fresh map. We couldn't get a client to completely hang, for some reason, but allowing something else to hog a single client's resources is enough to make a server unplayable for everyone.

Vl4dim1r commented 9 years ago

Was this issue ever sent off to Keen? I havn't heard any other mention of it.