Tyrsis / SE-Community-Mod-API

Space Engineers Community Modding API
GNU Lesser General Public License v3.0
23 stars 11 forks source link

Crash message when I close the window #5

Open biouxtai opened 9 years ago

biouxtai commented 9 years ago

Whenever I hit the stop button, wait for the server to stop, then close the window the following messages are printed:

2014-11-20 18:43:04.231 - Unloading plugin 'f625a48b-c28c-4ba4-a39a-637824614d0f' 2014-11-20 18:43:04.544 - Unloading plugin 'f767bda5-0a8c-4813-85fd-a5a2341778e8' 2014-11-20 18:43:04.545 - Shutting down plugin: Dedicated Server Essentials - 1.0.2.135 2014-11-20 18:43:04.546 - PluginProcessing(): System.Threading.ThreadAbortException: Thread was being aborted. at System.DateTime.GetDatePart(Int32 part) at System.TimeZoneInfo.GetDateTimeNowUtcOffsetFromUtc(DateTime time, Boolean& isAmbiguousLocalDst) at System.DateTime.get_Now() at EssentialsPlugin.Essentials.PluginProcessing() 2014-11-20 18:43:04.569 - Unloading plugin '774c4148-1da1-4ee0-b7f0-eb51ca296e9b' 2014-11-20 18:43:04.579 - Shutting down Blueprints Plugin Server has been stopped 2014-11-20 18:43:04.602 - Blueprints Processing Thread Closed: System.Threading.ThreadAbortException: Thread was being aborted. at System.Threading.Thread.SleepInternal(Int32 millisecondsTimeout) at BlueprintsPlugin.BlueprintsPlugin.BlueprintsThreadWork() 2014-11-20 18:43:04.785: Logging off Steam... 2014-11-20 18:43:04.785: Shutting down server... 2014-11-20 18:43:05.045: Done Server has stopped running at B337879D0C82A5F9C44D51D954769590.B3531963E948FB4FA1D057C4340C61B4.AA7B896DEC536D75F0BF53A47965F721() at B337879D0C82A5F9C44D51D954769590.B3531963E948FB4FA1D057C4340C61B4.4E2AA6D6083E86732C5C1CD1D6348375() at B337879D0C82A5F9C44D51D954769590.B3531963E948FB4FA1D057C4340C61B4.246E732EE67F7F6F88C4FF63B3901107(Boolean FF8E4184144DE7049FF5EC07D594DAB6) at 83BCBFA49B3A2A6EC1BC99583DA2D399.49BCFF86BA276A9C7C0D269C2924DE2D.523C8831DA5DAB3A19F6D33A2C6437B5() at 83BCBFA49B3A2A6EC1BC99583DA2D399.49BCFF86BA276A9C7C0D269C2924DE2D.26A7ABEA729FAE1F24679E21470F8E98(String 8BF03A34188889479CB413E58490FC37, String 48C45E39212AAA2B19C972DA9195F48A, Boolean 7AC487C1B445CD9F481CF5FE695A7CEA, Boolean 42 92A7A4DACAF323E558B7E11DD3CF00) at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor) at System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(Object obj, Object[] parameters, Object[] arguments) at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture) at System.Reflection.MethodBase.Invoke(Object obj, Object[] parameters) at SEModAPIInternal.API.Server.ServerAssemblyWrapper.StartServer(String instanceName, String overridePath, Boolean useConsole) at SEModAPIExtensions.API.Server.RunServer() at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Threading.ThreadHelper.ThreadStart()

Tyrsis commented 9 years ago

In order to stop the server, it has to be forcefully stopped. This is not a graceful way to stop something, but because of the nature of Extender, it's the only real way to do it and have it properly stop in services. This exception is a product of that. I can hide this exception, but there is no point, as the application is closing anyway.

Are you having an issue with something because of this error?

biouxtai commented 9 years ago

When an exception is shown on the screen, that tends to mean that something didn't happen that was supposed to, or something did happen that wasn't supposed to. Since this is a known exception that occurs due to the way that the server needs to be stopped, then it should be caught and muted. Otherwise people, like myself, are going to see this and think there is a bug in the program. If the exception is known, it should be handled gracefully.

Tyrsis commented 9 years ago

I agree it should be muted and most likely will be muted in future updates.