search

TysonAndre / lsp-phan

WIP to run Phan in LSP for emacs.
GNU General Public License v3.0
3 stars 0 forks source link

Will it work with lsp-php? #6

Open tam5 opened 5 years ago

tam5 commented 5 years ago

lsp-mode has recently gone through some major improvements and I believe https://github.com/emacs-lsp/lsp-mode/issues/105 was closed and completed to support multiple language servers for a major mode.

Given that, would lsp-phan work together with lsp-php? If so, would you mind providing some details on how to get that to work?

TysonAndre commented 5 years ago

I'd have to check, it's been a while and I haven't tested it out yet.

Hopefully, you could run them independently, unless there were bugs or other issues with the client.

EDIT: No, lsp-phan doesn't work with the latest lsp-mode version. You could try out the branch from #7 - I haven't had luck with more than one language server

TysonAndre commented 5 years ago

Also see https://github.com/emacs-lsp/lsp-php/issues/16 - The latest lsp-mode (5.0) isn't compatible with lsp-php, so you'd have issues.

PR #7 has diagnostics working with lsp-mode 5.0 (latest). I haven't tested all of the functionality yet.

When I tried requiring both lsp-phan and lsp-php, only lsp-php was able to start up. I haven't looked into it in that much depth. It could be related to workspaces, somehow.

If anyone has success running two php language servers (e.g. lsp-php and lsp-phan on the same file), please let me know what config you're using and how you set up the projects