TysonMN / tysonmn.github.io

Blog of Tyson Williams about software engineering and functional programming
https://tysonwilliams.coding.blog/
MIT License
3 stars 7 forks source link

Feature: Footer Icons #34

Open im-coder-lg opened 2 years ago

im-coder-lg commented 2 years ago

I successfully added footer icons for my site and since, my site is a fork of this one(this is much cooler), I am thinking, why not add it here too? The main icons are:

I can get the icons, but I need the profile ID for the redirect link. If you see my site, I added my GitHub, RSS, my Matrix and Gitter handles. I got all of them from Icons8, and converted them from PNG to SVG at Convertio. Can I help here by adding the footer icons?

TysonMN commented 2 years ago

I like the idea of adding icons in the footer. In my footer, I would consider a heart icon for sponsoring and RSS (and maybe the other ways to subscribe).

I indirectly link to my socials through my about page and then my about.me page. My current preference is to not also include icons for them in the footer.

Your site looks great too. Your icons also look good in the light theme, but I find them hard or impossible to see in the dark theme. Are you able to improve the contrast of the icons in the dark theme?

im-coder-lg commented 2 years ago

Using the coding.blog theme and am trying to add colorful ones. Should I add icons for you too? It's just simple.

im-coder-lg commented 2 years ago

I actually have the contrast part as a priority, and I am going to get that fixed by today/tomorrow.

TysonMN commented 2 years ago

I don't want icons if the contrast with the dark theme is bad, so I will wait and see what you come up with for your site.

im-coder-lg commented 2 years ago

I am curious, what if I get FULLY colorful ones, like, the RSS has a yellow color, then why not apply it for light AND dark mode?

Let me test that and if it works, I will apply HERE and on my site too. If you have any social media, then add it to your about.me, and I will add these icons:

TysonMN commented 2 years ago

A single icon might be ok for both light same dark mode if it looks good enough, but I would expect per-theme icons would look better.

im-coder-lg commented 2 years ago

Yup, same.