search

TysonStanley / tidyfast

Fast and efficient alternatives to tidyr functions built on data.table #rdatatable #rstats
https://tysonbarrett.com/tidyfast/
187 stars 4 forks source link

please remove capture.output from tests #52

Closed tdhock closed 9 months ago

tdhock commented 1 year ago

hi @TysonStanley The test files currently use capture.output, which depends on the default data.table printing behavior. For example https://github.com/TysonStanley/tidyfast/blob/master/tests/testthat/test-tidyfast.R#L147 Using the new data.table from github master, remotes::install_github("Rdatatable/data.table"), those tests fail because the new default is to print column types, whereas your expected output does not have any column types. Please update your test cases (remove capture.output) and submit a new version of tidyfast to CRAN. This will help facilitate releasing a new version of data.table to CRAN. (data.table devs must make sure all reverse dependencies do not break, before submitting a new version to CRAN)

tdhock commented 1 year ago

alternatively, if you must keep capture.output, then please set options(datatable.print.class=FALSE) before running your tests.