search

Tyzer34 / plexMusicPlayer

Playback music with Alexa from your Plex Server!
https://medium.com/@Tyzer34/plex-alexa-the-perfect-wedding-38b14b41faf0#.b71cd6lsn
GNU General Public License v3.0
35 stars 19 forks source link

Fork #6

Closed tdelesio closed 7 years ago

tdelesio commented 7 years ago

I ended up forking your code base mostly because I wanted to change the intents. I fixed a couple bugs in the methods.py when tracks, artists, and albums return multiple results. I just take the first one in the list and send it on its way. Here is the link if you want to see the code. I can push to your repo too if you would like.

https://github.com/tdelesio/plexMusicPlayer/blob/master/plexmusicplayer/methods.py

I also added two separate intents. From my testing, it seamed that the intents were getting confused. I would be asking for a track and/or album, and amazon thought I was looking for an artist. To try and make it less confused I added two more intents. Is there a better way to test this locally? I have been pushing to herkou everything but it is slow. I launched the server.py file locally and tried to post the json from the service simulator, but it gave me some token error (not the environment variables token).

Tyzer34 commented 7 years ago

It would be great if you wanted to help out with the project! Have you committed your changes yet? In you latest commit, I only see the logger being added. There is a better way to test locally! If you run server.py locally, it will be hosted on localhost:5000. Next, you can use ngrok to forward port 5000 to an external ip, which you can then link to your Alexa Skill. (command for ngrok would be ngrok http 5000)

tdelesio commented 7 years ago

I guess I didn't. It's there now. Check it out and let me know.

Tyzer34 commented 7 years ago

I saw your update! Seems great to me! I've added your changes to the current project! Thank you!

tdelesio commented 7 years ago

Yea if you make me a contributor, I will switch my code base back to yours and commit there going forward. I also changed some of the Intents which you may or may not like. I can keep those separate however

Tyzer34 commented 7 years ago

No problem, I'm glad you want to contribute! I would advise you though to make a separate private repository that contains a clone of this one. You can then use that private testing repository for trying out stuff. If you have something working, you can push the changed files to this public repository! This is just to keep the commits here clean and clear :)

tdelesio commented 7 years ago

Yea I forked it. I'll push my changes there first and then commit back to your repo.