Collection of suggestions

Jay-o-Way commented 6 months ago

Global

[ ] Use new icon for the repository → #37
[ ] Check accessibility (keyboard and Screen reader) 🧑‍🦯🧏 #137
[ ] CardControl - Card → #137
[ ] Re-do keybindings
[ ] Light or Dark theme handling → #137
[ ] Simplify the Background code (Mica) → #137
[ ] Don't hard-code things like colors, padding/size for buttons, cornerradius, fontsize... → #137
[ ] Set an icon property for the windows → #137

Some kind of window to show app info (like, at least version) → #21 #LargeWork

Idea for settings: do not build the type into the rule, but let this be a separate datum in the JSON file. This might make the code easier and removes the prefix, so users don't have to deal with this (read: can't make mistakes). #LargeWork Example:

    Type: "domain"
    Rule: "github.com"

BrowserSelection

[ ] Fix and simplify the min/max window size (and settings of it) → #137
[ ] When using TextBox: Opening a browser should use the value of the TextBox at that moment
[ ] + Rules does not add a rule, but opens a window to a manager → #137
[x] MaximizeWindow() → it's not really "maximized" → #136
[x] "TODO: try to remove the flashing" → #136

Ruleset / Edit window

[ ] Maybe use only a InfoBadge ? 6️⃣ #NoPriority
[ ] Replace "... (Browser)" with the icon of the browser? → saves space #NoPriority
[ ] ScrollViewer: full width and don't use a padding → #137
[x] "found" 6 rules
[x] move buttons inside the expander main area
[x] Don't use *.google.com as a placeholder. It looks exactly like actual data.
[x] After Add event, the Input control should be cleared and have focus, ready for quick entry for next rule input

Test window

[ ] Result for "Test against existing rule" should be as close to the button as possible.
[ ] use a control like an InfoBar to display succes/fail, not a color.
[ ] This window has a very different feeling from the Edit window.
[x] Also print the ruleset name.

U-C-S commented 6 months ago

Thanks once again for taking time to point out the issues.

Working on stability and documentation ones for now, Rest I shall come back to later

Jay-o-Way commented 6 months ago

Which two points are good for me to pick up (or help you with) ?

U-C-S commented 6 months ago

Oh didnt see your earlier message 😅. But you went and did it anyway.

These 2 would be great.

Control RulesetAccordion shouldn't be needed
move [edit/move/delete] buttons inside the expander main area: always accessible, even when collapsed

Also, I am planning for a rewrite of Hurl.BrowserSelector, which I feel is a mess of code. I will try implement most stuff along the way then. I am also trying design a new icon in figma (#37).

Jay-o-Way commented 5 months ago

Now that I've worked a bit on the code, that control isn't so bad. I would use a list, but that's not too difficult. I would also like to try and work on hardcoded colors, margins/paddings and so on.

U-C-S / Hurl