Support for sub-domain rules within domain rule type

U-C-S / Hurl

Choose the browser on the click of a link

MIT License

295 stars 11 forks source link

Support for sub-domain rules within domain rule type #107

Open Jay-o-Way opened 8 months ago

Jay-o-Way commented 8 months ago

U-C-S commented 8 months ago

should it work with docs.github.com domain rule , then it's working as intended. atleast for now.

Honestly I was confused about handling the case of sub-domains. Maybe In future, I can have extra option for also including sub-domains as a checkbox.

Jay-o-Way commented 8 months ago

I assumed that the rule would capture the top domain. Note that the example of *.domain.com literally implies a sub-domain 🤓