[DEMO] Loads of suggestions

Jay-o-Way commented 6 months ago

Hi,

I took the liberty to make some changes, hoping to help. Of course, this is how "I" would do things. It's your project and you are free to accept everything you want. Also, it might not be perfect right now, please do double-check.

Comments / details

TO-DO: check why IsEnabled="{Binding UseCustomRule.IsChecked}" doesn't work ⚠️
General tidy-up of XAML and layouts, incl. window sizes
Use a CheckBox for optional use of custom rule; merged the CS code together and use IF statement
Use an InfoBar to display the test result
Feel free to ask for more info

Screenshots

U-C-S commented 6 months ago

Woah, Thanks for this.... I can use your PR as starting phase to work on next set of stuff.

Of course, this is how "I" would do things. It's your project and you are free to accept everything you want

😅 yeh, I am kind of opinionated about some stuff, but I do like some of the things here, which I will salvage out of this.

U-C-S commented 5 months ago

Wouldn't this PR create conflicts with #114 once either of these are merged ??

Jay-o-Way commented 5 months ago

Oh yes. Definitely. This is a PR I made in a rather short time, mostly to demo ideas, as I would approach. You also have your personal ideas for the "re-write" milestone. In any case, it's always better to be more targeted with PRs.

U-C-S / Hurl

[DEMO] Loads of suggestions #109

Comments / details

Screenshots