search

U-C-S / Hurl

Choose the browser on the click of a link
MIT License
279 stars 10 forks source link

Width adjustment doesn't seem to work properly after updating. #110

Open sjain882 opened 6 months ago

sjain882 commented 6 months ago

Not 100% sure what my Hurl version was before (I think it was v0.7.1) but I recently updated to v0.8.3, and now the width reduced:

image

I tried adjusting it in the json file and reloading, but it didn't work. Tried resizing with mouse - it won't go any further.

Did 9999,9999 as a test and it looks like this:

image

I guess this is a new hard limit on the window size? I couldn't seem to spot anything like this while inspecting the source code...

Before, it accepted the large width without issues.

Jay-o-Way commented 6 months ago

Probably conflicting with https://github.com/U-C-S/Hurl/blob/ac90c3286c664121e1ed6de5a13c54730c77b41b/Source/Hurl.BrowserSelector/Windows/MainWindow.xaml#L12-L15 or https://github.com/U-C-S/Hurl/blob/ac90c3286c664121e1ed6de5a13c54730c77b41b/Source/Hurl.BrowserSelector/Windows/MainWindow.xaml.cs#L51-L55

Jay-o-Way commented 6 months ago

@sjain882 what numbers would be reasonable, if there would still be a min & max width & height?

Jay-o-Way commented 4 months ago

@sjain882 @U-C-S would it be alright to remove all the maxima?