U-C-S / Hurl

Choose the browser on the click of a link
MIT License
254 stars 8 forks source link

Unable to run Hurl on W10 #42

Closed cwichel closed 2 years ago

cwichel commented 2 years ago

Hi!

I'm having issues with running Hurl...

My system:

The installation process:

  1. Downloaded and installed .NET 6 Desktop Runtime x64.
  2. Installed Hurl from release v0.6.1 on default folder.

Issue: Tried to run Hurl but nothing happened:

Is there any step missing in the installation process? Is any other dependency/library required?

U-C-S commented 2 years ago

Thanks for reporting..... I haven't tested Hurl with Windows 10 properly. For now, I am assuming the App just crashed with some Error that's not handled properly.

I'll look into it in the coming week

hanjo commented 2 years ago

Hi - I'm having the same issue on Windows 11 21H2 (Build 22000.675). Application launches and immediatly crashes.

Issue is with 0.6.1 only, 0.6 works fine.

U-C-S commented 2 years ago

Issue is with 0.6.1 only, 0.6 works fine

@hanjo That's a good info and simplifies catching the exact bug.

U-C-S commented 2 years ago

Found the issue: image

Workaround

For now, Workaround is to " Manually create a directory Hurl under ...../AppData/Roaming ". So, Hurl can create the UserSettings.json file in it.


dev stuff

I handled this case pretty well in the code. But seems the code isn't getting called. https://github.com/U-C-S/Hurl/blob/53b721767315eeaa39aefc14a6c1c8ff782fcaef/App/Hurl.SharedLibraries/Services/SettingsFile.cs#L35

cc @hanjo , @cwichel

hanjo commented 2 years ago

Hi @U-C-S Thanks for providing this information. So this issue would only be affecting new users, where users upgrading from an older version should not be affected (since the folder and the file already exist). I tried this hypothesis and upgraded from 0.6 to 0.6.1, but still the application was crashing on startup, however I got a different error: hurl-crash

U-C-S commented 2 years ago

@hanjo Thanks once again... I am able reproduce this. Discovered that this part of the issue caused due to poor handling of #39 i.e. I forgot to make the fields optional.

For now, add the following to the UserSettings.json like seen in https://github.com/U-C-S/Hurl/discussions/40#discussioncomment-2613539

  "AppSettings": {
    "DisableAcrylic": false,
    "BackgroundRGB": [ 51, 51, 51 ]
  },
hanjo commented 2 years ago

Thanks, I can confirm that 0.6.1 is running fine (i.e. not crashing on startup) after adding the above to the config file.

cwichel commented 2 years ago

I can confirm the same as @hanjo

U-C-S commented 2 years ago

Fixed this in v0.6.2