search

U-C-S / Hurl

Choose the browser on the click of a link
MIT License
252 stars 8 forks source link

Building from Source improvements #76

Closed natevoci closed 10 months ago

natevoci commented 10 months ago

I found that the Building from Source instructions in README.md were missing a couple of things.

First, After checking out the repo I needed to do a git submodule init to load the Wpfui project.

Second, I was getting a build error because the CommunityToolkit.Labs.WinUI.SettingsControls package could not be found. Eventually I figured out I could fix this by adding this package source in the settings of the NuGet Package Manager https://pkgs.dev.azure.com/dotnet/CommunityToolkit/_packaging/CommunityToolkit-Labs/nuget/v3/index.json

U-C-S commented 10 months ago

Thank you....I missed documenting about the both the things u as i always had a local clone of repo, didn't think that would be a issue. I'll document on it soon. (Probably next week)

Additionally I was thinking to remove Wpfui project as dependency as it became troublesome for past few versions with its frequent changes to API and other bugs (like #71). I'm considering moving to WinUI 3/WinAppSDK soon to release v1.4

U-C-S commented 10 months ago

Temporarily removed use of wpfui git submodule (since a new stable version is released in Nuget) and Hurl Settings Project from sln project file (Will add it back when I have a working version)