search

U-C-S / Hurl

Choose the browser on the click of a link
MIT License
294 stars 10 forks source link

Auto Routing Rules don't apply Launch Args #80

Closed nathanbabcock closed 1 year ago

nathanbabcock commented 1 year ago

First off, thank you for the great program, it is designed so much nicer than other apps like it. 👏

Here's my understanding of the issue — in AutoRulesCheck.cs, the browser is started with this command:

Process.Start(x.ExePath, link);

It's missing the LaunchArgs part that is included elsewhere, such as BrowsersList.xaml.cs, there's some extra logic to include the LaunchArgs and apply them to the command:

Process.Start(browser.ExePath, Link + " " + browser.LaunchArgs);

For reference, my use case is this: I have a different Github account for my work, and a separate Chrome profile where I'm logged into my work Github. But when I click PR links in Slack, it randomly opens in either my default profile or the work profile (whichever one I most recently opened a tab in).

U-C-S commented 1 year ago

Yes, I will release a new version soon to add this. Thanks for me making aware of this.