U-Shift / biclar

Strategic cycle network planning tools, evidence and reproducible code
https://u-shift.github.io/biclar/
GNU Affero General Public License v3.0
4 stars 3 forks source link

Build failing #30

Closed Robinlovelace closed 1 year ago

Robinlovelace commented 2 years ago

I've tried a few different ways but guess the quickest now may be to replace cols4all with another package, and remove kableExtra.

temospena commented 2 years ago

can we replace by the color palette itself? mako and rocket comes from "viridis", blues comes from "brewer", and so on

Robinlovelace commented 2 years ago

Yes, we could do :+1:

temospena commented 2 years ago

or put this function file in our R folder, and not import cols4all? https://github.com/mtennekes/cols4all/blob/main/R/c4a.R

i have no ideia if it works, only a guess.

Robinlovelace commented 2 years ago

You could try this: https://github.com/moodymudskipper/burglr also cols4all should be on CRAN soon :pray: thanks to progress by @mtennekes

temospena commented 2 years ago

cool! we can wait to be on cran, then.

if we need meanwhile, I can try burglr, but then I'm not sure how to remove cols4all to dependencies and add to description.

mtennekes commented 2 years ago

You're welcome @Robinlovelace Glad that cols4all is already used :-) Happy to receive feedback at https://github.com/mtennekes/cols4all/issues/18

temospena commented 1 year ago

solved, after cols4all to be on CRAN

changed parameters at https://github.com/U-Shift/biclar/blob/master/.github/workflows/pkgdown.yaml using JamesIves/github-pages-deploy-action@v4.4.1