U-Shift / biclar

Strategic cycle network planning tools, evidence and reproducible code
https://u-shift.github.io/biclar/
GNU Affero General Public License v3.0
4 stars 3 forks source link

jittering + overline #32

Closed temospena closed 2 years ago

temospena commented 2 years ago

I think there is some issue with the overline, from the jittered routes (max treshold = 100) I don't understand why all segments at rnet (after overline, with fun = "sum" of Bike) have a number of cycling trips (Bike) and a bike percentage (bikeper) with a reason of 1/100. image

This is happening for all segments, which doesn't make sense. image

Shouldn't the the overlined segment have a higher bike percentage when is "thiker"?

temospena commented 2 years ago

I think that the problem is here:

rnet_allmodesNSub2_overline = routes_allmodesNSub2_filtered %>%
  stplanr::overline(c("Bike", "Bikeper", "new_cyc10", "cyc10"),
                    fun = "sum")
temospena commented 2 years ago

Updated as

rnet_allmodesNSub2_overline = routes_allmodesNSub2_filtered %>%
  stplanr::overline(c("Bike", "Total", "new_cyc10", "cyc10"),
                    fun = "sum") %>% 
  mutate(Bikeper = Bike / Total)

ok, now this makes more sense :) image