search

UAL-RE / LD-Cool-P

Python tool to enable data curation
MIT License
4 stars 5 forks source link

Bug: update_readme script fails when there's no Deposit Agreement #244

Open astrochun opened 3 years ago

astrochun commented 3 years ago

Describe the bug

A couple of weeks ago I was doing some testing of the scripts and noticed an issue. The update_readme script failed. This was a stage deposit that didn't have a Deposit Agreement form. For reference, the Deposit Agreement is gather for the Corresponding Author metadata. This is done in the early stages to populate dict's for the README input. This is very much an edge case situation as most deposits will have a Deposit Agreement. This issue is mostly as a reminder. I'll try to find the old error message or recreate it.

Reproduction Steps

I'll see if I can find it, but it involves running update_readme with a deposit that does not have a Deposit Agreement

Outputted Messages

I'll see if I can recreate the error message/track back.

Version information

Expected behavior

In such a case, it should warn that a Deposit Agreement is not available and either:

  1. Exit gracefully, or
  2. Ask whether to proceed with NaN filled in.

Screenshots

Additional context

Implemented in: TBD