UAL-RE / redata-commons

Commons code used by ReDATA codebases
MIT License
1 stars 2 forks source link

Enhancement/doc #39

Closed yhan818 closed 1 year ago

yhan818 commented 1 year ago

Description

See #36 It is a dependency upgraded to the latest version. Requests is a simple HTTP library.

Screenshots or additional context

Testing (if applicable)

All redata codes shall be performed as usual, because requests' upgrade to the latest version (2.31.0) shall have no impact to redata.

zoidy commented 1 year ago

This PR needs downstream testing before being merged into main. From the requests library changelog :

LD-Cool-P uses the urllib library directly as well as chunked downloads. ReBACH uses chunked downloads. Therefore, before merging this PR, the following tests are needed. With the latest requests library, test

zoidy commented 1 year ago

Tests needed for approval. See above

After thinking about it, I think this can be merged now and the testing done at the time the update is applied to each dependent repo. LD-Cool-P and ReBACH are pinned to v0.42 and 0.41 of redata commons respectively so updating this code won't affect them right away. I'll create an issue in those repos to update this dependency and test it.

yhan818 commented 1 year ago

Tests needed for approval. See above

After thinking about it, I think this can be merged now and the testing done at the time the update is applied to each dependent repo. LD-Cool-P and ReBACH are pinned to v0.42 and 0.41 of redata commons respectively so updating this code won't affect them right away. I'll create an issue in those repos to update this dependency and test it.

Both shall be tested and applied. In addition, dependencies (pandas and tabulate) new versions were released. Probably these shall be upgraded at the same time.