UAL-RE / redata-commons

Commons code used by ReDATA codebases
MIT License
1 stars 2 forks source link

Add git_info module; Include create release GitHub Actions; Include PyPI publishing GitHub Actions #4

Closed astrochun closed 3 years ago

astrochun commented 3 years ago

Closes #2 Closes #3 Closes #6

Commit history:

astrochun commented 3 years ago

I was able to build locally. Except for a minor fix, everything looks good. I was wondering if we should test it on https://test.pypi.org/

What was the minor fix that was needed?

Yes, we can publish say v0.0.1 to test PyPI. Note that versioning is fix on PyPI. Once you publish you can't re-publish with the same version. It's not like GitHub where you can delete a tag to re-tag it. The final version of this release is 0.1.0 so that won't be an issue here. You can pip install --index-url https://test.pypi.org/simple/ redata=0.1.0 to use Test PyPI. Once I have it published I'll note it in the PR.

damian-romero commented 3 years ago

Yes, we can publish say v0.0.1 to test PyPI. Note that versioning is fix on PyPI. Once you publish you can't re-publish with the same version. It's not like GitHub where you can delete a tag to re-tag it. The final version of this release is 0.1.0 so that won't be an issue here. You can pip install --index-url https://test.pypi.org/simple/ redata=0.1.0 to use Test PyPI. Once I have it published I'll note it in the PR.

Sounds good. I'll be on the lookout for when you want me to merge this into main. If I understand correctly, this repository will be using GitHub flow instead of git flow.

astrochun commented 3 years ago

I did publish v0.0.1 to Test PyPI: https://test.pypi.org/project/redata/

pip install -i https://test.pypi.org/simple/ redata==0.0.1 should work