search

UASF / bitcoin

Bitcoin Core UASF BIP148. Download:
https://github.com/UASF/bitcoin/releases
MIT License
62 stars 6 forks source link

A make check test fails with "bad-no-segwit" message #41

Open UncleHunto opened 7 years ago

UncleHunto commented 7 years ago

Describe the issue

Some of the make check tests are failing with a "bad-no-segwit" message. I have included the contents of my test-suite.log file for further details

Can you reliably reproduce the issue?

Yes

If so, please list the steps to reproduce below:

  1. Build UASF bitcoin core from source.
  2. Run make check tests.

Expected behaviour

Tell us what should happen All tests should be passed.

Actual behaviour

Tell us what happens instead One test failed.

What version of bitcoin-core are you using?

List the version number/commit ID, and if it is an official binary, self compiled or a distribution package such as PPA.

Arch AUR package: bitcoin-uasf-git v0.14.2.uasfsegwit1.0.r0.g2e7690fc8-1-x86_64

Machine specs:

Any extra information that might be useful in the debugging process.

This is normally the contents of a debug.log or config.log file. Raw text or a link to a pastebin type site are preferred.

=============================================
   Bitcoin Core 0.14.2: src/test-suite.log
=============================================

# TOTAL: 2
# PASS:  1
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: test/test_bitcoin
=======================

Running 229 test cases...
unknown location(0): fatal error: in "miner_tests/CreateNewBlock_validity": std::runtime_error: CreateNewBlock: TestBlockValidity failed: bad-no-segwit (code 16)
test/miner_tests.cpp(204): last checkpoint
unknown location(0): fatal error: in "tx_validationcache_tests/tx_mempool_block_doublespend": std::runtime_error: CreateNewBlock: TestBlockValidity failed: bad-no-segwit (code 16)
test/test_bitcoin.cpp(76): last checkpoint
unknown location(0): fatal error: in "wallet_tests/rescan": std::runtime_error: CreateNewBlock: TestBlockValidity failed: bad-no-segwit (code 16)
test/test_bitcoin.cpp(76): last checkpoint
unknown location(0): fatal error: in "wallet_tests/importwallet_rescan": std::runtime_error: CreateNewBlock: TestBlockValidity failed: bad-no-segwit (code 16)
test/test_bitcoin.cpp(76): last checkpoint

*** 4 failures are detected in the test module "Bitcoin Test Suite"
FAIL test/test_bitcoin (exit status: 201)
luke-jr commented 7 years ago

Not surprising. Most likely these began failing because your system clock is now past Aug 1.

I'll investigate fixing it more in a few days unless someone else gets to it first.

Note this is a bug in the tests, not the node itself - running UASF/bitcoin should still be safe.