UAlbanyArchives / mailbagit

A tool for creating and managing Mailbags, a package for preserving email using multiple preservation formats

https://archives.albany.edu/mailbag/

MIT License

46 stars 2 forks source link

First pass at structlog configuration. #207

Closed pobocks closed 2 years ago

pobocks commented 2 years ago

Type of Contribution

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New component
[x] Refactoring (no functional changes)
[ ] Documentation-only

What does this implement/fix? Explain your changes.

This implements a structlog configuration that:

is only applied if the app is run via main - if it's being imported for use as a library no log configuration is done
supports passing a filename in the args
supports configuration via log variables ...

Link to issue?

83

...

[ ] Issue closed
[x] Remain open

Pull Request Checklist

Please check if your PR fulfills the following requirements:

[x] Make sure you are requesting to the develop branch. Don't PR to main!
[ ] This contribution has sufficient documentation
[ ] Tests for the changes have been added
[ ] All tests pass

How has this been tested?

Operating System: … Python Version: …

Licensing

[x] I agree that the Mailbag Project and the University at Albany, SUNY can release this code under the MIT license.

pobocks commented 2 years ago

Note: this isn't complete - documentation at minimum is needed, and I think there needs to be a discussion about how we want logs to work in some more detail. But this should do what was being done before, at minimum, with the addition of being trivially redirectable to a file - I don't have as good a collection of sample data to run it over, @gwiedeman, so if you'd test that part out I'd be very obliged.