Update pdf-chrome derivative - Githubissues

UAlbanyArchives / mailbagit

A tool for creating and managing Mailbags, a package for preserving email using multiple preservation formats

https://archives.albany.edu/mailbag/

MIT License

46 stars 2 forks source link

Update pdf-chrome derivative #248

Closed jtruitt1 closed 6 months ago

jtruitt1 commented 8 months ago

Type of Contribution

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New component
[ ] Refactoring (no functional changes)
[ ] Documentation-only

What does this implement/fix? Explain your changes.

Update outdated Chrome CLI parameter
Expand list of possible chromes to include default name for Chrome CLI on macOS
Add documentation for macOS users to add Chrome CLI to their PATH

Pull Request Checklist

Please check if your PR fulfills the following requirements:

[x] Make sure you are requesting to the develop branch. Don't PR to main!
[x] This contribution has sufficient documentation
[ ] Tests for the changes have been added
[x] All tests pass

How has this been tested?

Operating System: macOS Ventura 13.5 Python Version: Python 3.9.5

Licensing

[x] I agree that the Mailbag Project and the University at Albany, SUNY can release this code under the MIT license.

gwiedeman commented 6 months ago

I don't have access to a mac, so I can't easily test this. Its odd to me that Google\ Chrome would work, but this is only additive, so I'm fine merging it, as even if its not the ideal install or whatever if it helped you it should help someone else.

Thanks also for catching the --no-pdf-header-footer flag change!