search

UAlbertaALTLab / crk-db

Managing the Plains Cree dictionary database
https://itwewina.altlab.app/
GNU General Public License v3.0
0 stars 3 forks source link

remove literal meaning from semantic definition #92

Closed dwhieb closed 2 years ago

dwhieb commented 2 years ago

The semantic definition was often including undefined in the text of the definition. This was caused by how the semanticDefinition property was being populated. It interpolated the core definition + literal definition, but without checking that the literal definition existed first.

Since the definition fields need to be overhauled, I simply removed the literal meaning from the semantic definition for the time being. It will be re-added when all the definition fields are updated.

dwhieb commented 2 years ago

Tests are failing because ALTLab's server is down, so the latest FSTs can't be retrieved from ALTLab's git LFS. Tests are passing locally however, so I'm merging this now.