search

UAlbertaALTLab / korp-frontend

Frontend for Korp, a frontend for the IMS Open Corpus Workbench (CWB).
https://spraakbanken.gu.se/en/tools/korp
MIT License
1 stars 1 forks source link

lefthand context in KWIC results broken #10

Closed dwhieb closed 3 years ago

dwhieb commented 3 years ago

The lefthand side of the KWIC results shows the correct token, but the wrong information for that token. The righthand context is working.

Test Case: ê-itôtahk should have wapemaw to the left Current production version: http://altlab.ualberta.ca/korp/ Current development version: https://korp.altlab.dev/

Next up:

dwhieb commented 3 years ago

This is how the data is being returned from the server in the XHR:

[
  {
    "word": " witnesses s.o."
  },
  {
    "word": "\u00ea-it\u00f4tahk",
    "lemma": "it\u00f4tam",
    "msd": "PV.e.V.TI.Cnj.Prs.3Sg",
    "dep": "pred.ti",
    "gloss": "s/he does s.t. thus, s/he does thus, s/he acts thus"
  },
  {
    "word": ",",
    "lemma": ",",
    "msd": "CLB",
    "dep": null,
    "gloss": "__UNDE"
  }
]

These results are then passed to kwicCallback. This could mean that the query is incorrect, or the server is returning unexpected data.

dwhieb commented 3 years ago

The query being sent to the server:

default_context=1+sentence&show=sentence%2Cmsd%2Cgloss%2Clemma%2Cdep&show_struct=text_author%2Ctext_title%2Ctext_title1%2Ctext_title2%2Ctext_lang&start=0&end=24&corpus=WOLFART_AHENAKEW&cqp=%5Bword+%3D+%22%C3%AA-it%C3%B4tahk%22%5D&query_data=&context=WOLFART_AHENAKEW%3Aundefined&incremental=true&default_within=sentence&within=

In JSON format:

{
  "default_context": "1 sentence",
  "show":            "sentence,msd,gloss,lemma,dep",
  "show_struct":     "text_author,text_title,text_title1,text_title2,text_lang",
  "start":           "0",
  "end":             "24",
  "corpus":          "WOLFART_AHENAKEW",
  "cqp":             "[word = \"ê-itôtahk\"]",
  "query_data":      "",
  "context":         "WOLFART_AHENAKEW:undefined",
  "incremental":     "true",
  "default_within":  "sentence",
  "within":          ""
}
dwhieb commented 3 years ago

Tested out a fix on the dev server. The KWIC context is now working fine. Will finalize the fix, and add documentation for it and the deployment process, and redeploy before closing this issue.