UAlbertaALTLab / morphodict

Plains Cree Intelligent Dictionary
https://itwewina.altlab.app/
Apache License 2.0
22 stars 11 forks source link

Fixed (re-)coding of inclusive first person plural tags from English FST a… #1007

Closed aarppe closed 2 years ago

aarppe commented 2 years ago

Recode English FST analysis for inclusive first person plural with 21 to crk FST format with 12 (for actor: +21Pl -> +12Pl, goal: +21PlO -> +12PlO, and possessor: +Px21Pl -> +Pxl12Pl).

Based on local version seems to work, but one yet needs to check whether one more change is needed concerning the possessor tags in crk_tag_map.py.

This addresses issues #1005 (point 3), #1006 (question 2), and this earlier comment https://github.com/UAlbertaALTLab/morphodict/issues/875#issuecomment-888722609.

codecov-commenter commented 2 years ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.09%. Comparing base (b6cfb7d) to head (45176d9). Report is 724 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1007 +/- ## ========================================== + Coverage 79.07% 79.09% +0.01% ========================================== Files 151 151 Lines 5256 5256 Branches 675 675 ========================================== + Hits 4156 4157 +1 Misses 975 975 + Partials 125 124 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aarppe commented 2 years ago

@nienna73 @dwhieb @andrewdotn This seems to fix this matter, though there is this one detail (noted above that should be checked). I somehow thought that we had already changed this, but it must have been eclipsed by other matters.

I believe Andrew's explanation also clarifies why the tensed verb forms with any of the preverbs do not work (any more), but how to resolve that needs some careful thinking.

I tried to check that this doesn't break any tests, and if this is the case, then I do think this can be deployed.