Closed aarppe closed 2 years ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 79.09%. Comparing base (
b6cfb7d
) to head (45176d9
). Report is 724 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@nienna73 @dwhieb @andrewdotn This seems to fix this matter, though there is this one detail (noted above that should be checked). I somehow thought that we had already changed this, but it must have been eclipsed by other matters.
I believe Andrew's explanation also clarifies why the tensed verb forms with any of the preverbs do not work (any more), but how to resolve that needs some careful thinking.
I tried to check that this doesn't break any tests, and if this is the case, then I do think this can be deployed.
Recode English FST analysis for inclusive first person plural with
21
to crk FST format with12
(for actor:+21Pl
->+12Pl
, goal:+21PlO
->+12PlO
, and possessor:+Px21Pl
->+Pxl12Pl
).Based on local version seems to work, but one yet needs to check whether one more change is needed concerning the possessor tags in crk_tag_map.py.
This addresses issues #1005 (point 3), #1006 (question 2), and this earlier comment https://github.com/UAlbertaALTLab/morphodict/issues/875#issuecomment-888722609.