UAlbertaALTLab / morphodict

Plains Cree Intelligent Dictionary
https://itwewina.altlab.app/
Apache License 2.0
22 stars 11 forks source link

Behaviour when entry only has "form of" definition #1044

Closed nienna73 closed 2 years ago

nienna73 commented 2 years ago

Related to #1036

When implementing #1036, I now remove any entries that do not have a definition. This impacts the behaviour of auto-definitions.

The current behaviour:

Screen Shot 2022-01-07 at 1 11 15 PM

niminôsak appears in the results, but does not have its own definition, just the "form of" definition.

The new behaviour:

Screen Shot 2022-01-07 at 1 11 24 PM

Since niminôsak doesn't have a definition, it was removed from the results entirely.

Behaviour when logged in:

Screen Shot 2022-01-07 at 1 11 33 PM

The auto-definition for niminôsak always appears when users are logged in.

Of the first two behavious, which is the desired behaviour for production? @aarppe @dwhieb do you have thoughts on this issue?

nienna73 commented 2 years ago

This question was answered during a meeting. The first screenshot displays the expected behaviour.