search

UAlbertaALTLab / morphodict

Plains Cree Intelligent Dictionary
https://itwewina.altlab.app/
Apache License 2.0
22 stars 11 forks source link

fix: relabelling for info table #1067

Closed nienna73 closed 2 years ago

nienna73 commented 2 years ago

Relabelling for the info table seems to be working now. Here are the three different modes:

Linguist:

Screen Shot 2022-03-30 at 10 45 55 AM

English:

Screen Shot 2022-03-30 at 10 46 06 AM

Tsuut'ina:

Screen Shot 2022-03-30 at 10 46 21 AM

@aarppe Does this look correct now?

aarppe commented 2 years ago

Yes, it looks as it should. In the revised srseng dictionary DB I currently only have two columns, since the TVPB1 doesn't have the TAMA chunks, nor the LEXC-style lexical tier representation, so I'm just giving an example 3rd person singular verb form per aspect. But my understanding of the table implementation is that it really is up to the linguist how the table is specified and what content it has. One question I would have is how is the header row boldfacing specified? By <b>...</b> tags in the table? I'm asking this as the code looked like it would remove such boldfacing fields.

nienna73 commented 2 years ago

The table specification is entirely up to the linguist, yes. The <b> tags are removed for relabelling only, I do that so I can find the text from within them, but I don't actually remove them from the final product. So far, this is the only tag except from the regular table ones that is supported.

aarppe commented 2 years ago

Ok, good - and I've added a revised version of the srs-to-eng DB, that makes use of the tabular format, cf. https://github.com/UAlbertaALTLab/morphodict/blob/main/src/srseng/resources/dictionary/srseng_test_db.importjson - so eventually we could update the DB on the production site.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.06%. Comparing base (db97405) to head (6eb016a). Report is 486 commits behind head on main.

Files Patch % Lines
src/CreeDictionary/API/search/presentation.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1067 +/- ## ========================================== + Coverage 78.03% 78.06% +0.02% ========================================== Files 151 151 Lines 5459 5457 -2 Branches 875 875 ========================================== Hits 4260 4260 + Misses 1066 1064 -2 Partials 133 133 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.