UAlbertaFSAE / f1tenth

MIT License
0 stars 0 forks source link

fix missing rmw installation and update docs #67

Closed Jquinny closed 2 months ago

Jquinny commented 2 months ago

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it relates to an open issue, be sure to link to that issue. Ensure that you add a label to the PR describing the type of change (if the issue does not have one already for whatever reason).

just a quick fix for a broken sim container due to missing rmw cyclone installation. updated documentation for new members to do the export ... stuff in their containers if they are running windows.

closes #66

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Jquinny commented 2 months ago

I need to figure out why merge checks are blocking. Will test with a changed file in src/ to see if the checks skipping when no changes in src/ is causing the blockage.

github-actions[bot] commented 2 months ago

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by OX Security_

github-actions[bot] commented 2 months ago

Cpp-Linter Report :heavy_check_mark:

No problems need attention.

Have any feedback or feature suggestions? Share it here.

Jquinny commented 2 months ago

I need to figure out why merge checks are blocking. Will test with a changed file in src/ to see if the checks skipping when no changes in src/ is causing the blockage.

looks like having the linters be required status checks on the main branch means they MUST run, even if no changes to src/ directory have been made. We might just have to eat it and have the checks run even when no changes to src/ directory have been made (this should be fine since the linter actions are set to run checks only on changed files I believe).