github-actions[bot]
commented
1 month ago 🦙 MegaLinter status: ✅ SUCCESS
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|
See detailed report in MegaLinter reports
_Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_
_MegaLinter is graciously provided by 
_
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it relates to an open issue, be sure to link to that issue. Ensure that you add a label to the PR describing the type of change (if the issue does not have one already for whatever reason).
we use a lot of third party python packages that have not implemented static typing, so mypy shits a brick when following imports. I just removed the check so we don't have to worry about static typing in anything but our own code.
Clangd on the vscode side of things skips some slow checks still (even with
FastCheckFilter: Nonein the .clangd file), even if they aren't skipped in the .clang-tidy file. Had to remove the misc-const-correctness check because of this. The include cleaning check got removed from both clangd and clang-tidy since the ROS headers are so spread out we would have so many includes in our code. Not sure if this is okay practice but it's less annoying for new members if I remove it.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...