search

UB-Heidelberg / omp

Open Monograph Press
http://pkp.sfu.ca/omp
0 stars 0 forks source link

Public Identifier Plugins #22

Closed withanage closed 8 years ago

withanage commented 8 years ago

Custom settings for urn and doi plugin fails. plugin @asmecher Can it be that the plugin structure basically changed after https://github.com/pkp/pkp-lib/commit/e678078cf1717bd9785b446f84037eeda969fa9d and modifications are needed in the plugin-level.

Confirmation 1 Static page plugin has this kind of options and work as intented.

asmecher commented 8 years ago

Thanks, @withanage, I'll take a look. @bozana, I know you'll be working on this stuff shortly, but this is my bug so I'll fix it :)

asmecher commented 8 years ago

I've committed fixes to both OJS and OMP master branches to get the settings forms working. By the way, was this OJS you were testing, or OMP? The OMP master branch doesn't have a URN plugin.

kadowa commented 8 years ago

OMP -- I've implemented a URN DNB plugin for OMP (similar to the one by @bozana for OJS). I borrowed a lot of code from the DOI plugin, so I can probably apply the same fixes. Thanks for the quick reply!

withanage commented 8 years ago

Thanks a lot for fixing it. looks good.