search

UB-Mannheim / ocr-fileformat

Validate and transform various OCR file formats (hOCR, ALTO, PAGE, FineReader)
https://digi.bib.uni-mannheim.de/ocr-fileformat/
MIT License
176 stars 23 forks source link

Implement command line option --version #101

Closed stweil closed 4 years ago

stweil commented 4 years ago

This addresses issue #87. It is based on top of PR #100.

Still missing: The web interface should also display the version.

zuphilip commented 4 years ago

Okay, so I see currently in this branch the version v0.1.0-132-ge1deaab, but I think we want the additional --tags option, i.e.:

$ git describe --tags
v0.2.3-48-ge1deaab

I cannot say much more about the code, because I don't understand most of the lines your wrote (besides the obvious ones:).

stweil commented 4 years ago

I think we want the additional --tags option.

The v0.2.x tags were created as lightweight tags instead of annotated tags and are not used therefore. Citing man git-tag:

Annotated tags are meant for release while lightweight tags are meant for private or temporary object labels. For this reason, some git commands for naming objects (like git describe) will ignore lightweight tags by default.

We should create the next release with an annotated tag. Then the code will work as expected.

zuphilip commented 4 years ago

Hm... but why not use git describe --tags anyways as it fixes the situation we have at the moment?

zuphilip commented 4 years ago

Thank you @stweil for all the work!