search

UB-Mannheim / ocr-fileformat

Validate and transform various OCR file formats (hOCR, ALTO, PAGE, FineReader)
https://digi.bib.uni-mannheim.de/ocr-fileformat/
MIT License
176 stars 23 forks source link

Add missing semicolon in escaping of backslash #64

Closed zuphilip closed 6 years ago

zuphilip commented 6 years ago

This seems to fix the encoding problem mentioned in #60 without any other negative effect.

kba commented 6 years ago

Why must strings use double quotes? Not that I'm against uniform coding style but I'd use eslint for that. Double / single quotes are interchangeable (apart from escaping quotes) in JS, unlike in PHP, Perl. These stylistic changes make it hard to spot what actually changed in this PR.

zuphilip commented 6 years ago

The explanation for consistent use of quotes: https://eslint.org/docs/rules/quotes . Do you think we should not try to follow that?

@kba Would it help, when the commit for codacy is taken out here and added in a separate PR?

stweil commented 6 years ago

Personally I prefer pull requests which address a single issue.

zuphilip commented 6 years ago

Okay, I splitted the commits into several PR. Can you look at them and hopefully merge them?

stweil commented 6 years ago

Thanks. https://digi.bib.uni-mannheim.de/ocr-fileformat-test/ now includes the latest fixes.