UB-Mannheim / zotero-ocr

Zotero Plugin for OCR
GNU Affero General Public License v3.0
551 stars 40 forks source link

OCR option not in Z7 context menu #67

Closed gravybot closed 7 months ago

gravybot commented 7 months ago

I'm using Zotero 7 on a mac, trying to OCR a pdf on Zotero 7. This was working fine a week ago in Zotero 6, with the latest version of the addon installed and all the same settings (i.e. tesseract pathways etc). I was waiting for OCR and translate addons to work with Z7 - now that they both do (thank you!!) I've moved across. The addon appears to be installed properly, and the settings correct in the Zotero preferences (as far as I can tell). So has something changed in the latest version of Zotero or the addon that means it's not appearing in the context menu?

stweil commented 7 months ago

The context menu works for me (latest MacOS on M2).

gravybot commented 7 months ago

Ok, strange. Thanks. Hopefully it's just a local issue for me.

aborel commented 7 months ago

Which exact Zotero version are you running? Does Zotero-OCR appear uin the context menu if you disable all other plugins?

BoseJohnson commented 7 months ago

I have the same issue after the z7 update , I am using W10.

stweil commented 7 months ago

If it does not work: do you see anything which looks related in Zotero's error console (tools - developer - error console)?

BoseJohnson commented 7 months ago

zotero_JtfLOaoOPN

stweil commented 7 months ago

~That explains why you don't get the context menu: it is registered in the startup method.~

It looks like the startup method for zotero-ocr is not run at all, because it should show a message "Starting".

Therefore nothing of the plugin will work, no context menu and also no entry in the "Zotero Settings" menu.

stweil commented 7 months ago

The console log refers to zotero-ocr.js:5. That code is Components.utils.import("resource://gre/modules/osfile.jsm");. So the question is why does this import statement not find that resource file?

stweil commented 7 months ago

Which exact Zotero version are you running? Does Zotero-OCR appear uin the context menu if you disable all other plugins?

@BoseJohnson and @gravybot, are you using the very latest version of Zotero 7?

BoseJohnson commented 7 months ago

7.0.0-beta.73+398454f85 (64-bit)

stweil commented 7 months ago

I still have 7.0.0-beta.68+c31a40c74, so yours is newer. I'll update later, maybe the newer version causes the problem.

aborel commented 7 months ago

I can reproduce the problem with beta72. Apparently a few non-trivial changes were introduced around beta 70, with impact on some plugins. I don't know the details yet, but we can check for example https://github.com/retorquere/zotero-better-bibtex/issues/2829#issuecomment-2048548752

ETA: the relevant discussion on zotero-dev seems to be https://groups.google.com/g/zotero-dev/c/wirqnj_EQUQ

gravybot commented 7 months ago

I'm on 7.0.0-beta.72+128a540af, and get the same startup error in the console.

aborel commented 7 months ago

Most likely cause: https://www.zotero.org/support/dev/zotero_7_for_developers#firefox_102_firefox_115 This doesn't look too difficult to fix, all we need is a tiny bit of time to update a couple of source code lines. I'll try to take care of it over the week-end (unless someone else deals with it on Friday).

aborel commented 7 months ago

I think I have a working version now, src/zotero-ocr.js is the only changed file. @stweil @zuphilip do you prefer a pull request for that, or should I just create a 0.7.1 release?

stweil commented 7 months ago

If you create a pull request, that will be automatically added to the release notes (unless you write them manually). But you can create the release either way. Please just make sure that you create an annotate tag in git (we did not always do that in the past).

aborel commented 7 months ago

Fixed in bc9f52a46341ff14f512f0456acbb3748283dec2 I should have let Github build the 0.7.1 release automatically instead of doing it myself, but it looks OK.

gravybot commented 7 months ago

You are all brilliant. Now seems to be working. Thank you!

stweil commented 7 months ago

The 0.7.1 release also works for me with 7.0.0-beta.73+398454f85 on macOS. Therefore I close the issue.