search

UB-Mannheim / zotero-ocr

Zotero Plugin for OCR
GNU Affero General Public License v3.0
551 stars 40 forks source link

Document names with spaces don't work on Windows #7

Closed stweil closed 3 years ago

stweil commented 5 years ago

In a test on Windows, the OCR failed when the name of the PDF includes space characters.

The same test still has to be done for Linux and macOS.

pmwills commented 4 years ago

I am having the same problem.

To add, I can run the relevant commands (after installing poppler) from the command line with success, provided the command and file names are wrapped in the necessary quotes. But what appears to be the same command does not work when run from the extension.

As far as I can tell, the extension relies on Zotero.Utilities.Internal.exec to handle the Windows-specific side of this, and Zotero.Utilities.Internal.exec in turn relies on nsiProcess. I've been unable to trace it further than that.

zuphilip commented 3 years ago

Is this still a problem in the newest version?

It works fine for me on Windows in version 0.4.0 also for PDFs with spaces.

serovar commented 3 years ago

Works for me too on Windows 10, thanks

stweil commented 3 years ago

Thanks for testing. So I think this issue can be closed.