search

UBC-DSCI / data-science-a-first-intro-worksheets

Worksheets to accompany Data Science: A First Introduction
https://worksheets.datasciencebook.ca
Other
25 stars 49 forks source link

46 is NOT 75% of 59 #6

Closed ValYourPal closed 1 year ago

ValYourPal commented 1 year ago

This is causing multiple errors since the original numbers seem to be baked into the solution

trevorcampbell commented 1 year ago

@ValYourPal thanks for the PR -- my guess is that this is a difference in rng behaviour at some point in the notebook caused by differing software versions between our docker image and your machine. We can't just change the test code -- it'll probably break the notebook in our docker image. We probably instead need to make this test a bit less strict.

trevorcampbell commented 1 year ago

Yep, tested and indeed this works fine in our docker image ubcdsci/r-dsci-100 from DockerHub. So I'm closing this. But I've opened an issue to make the textbook clearer re: setting up one's machine to make sure it has the right environment for our worksheets (https://github.com/UBC-DSCI/introduction-to-datascience/issues/484) as well as an issue in the worksheets repo to reference those instructions #8