search

UBC-DSCI / introduction-to-datascience-python

Open Source Textbook for DSCI100: Introduction to Data Science in Python
https://python.datasciencebook.ca
Other
12 stars 9 forks source link

Update to altair 5.1.2 to fix histrogram chart #277

Closed joelostblom closed 10 months ago

joelostblom commented 11 months ago

The chart above the "Choosing a binwidth" heading is not showing up correctly (the histograms are missing). I am not sure what the exact issue is but upgrading altair in the docker image and rebuilding fixed it for me locally, so I'm suggesting we do that.

Oddly enough this issue does not show up in jupyter lab, just when building the charts via jupyter book.

Current: image

After fix (the figure number is different because I didnt' build the entire book locally to save time): image

trevorcampbell commented 10 months ago

Hmm, why didn't github actions run on this PR?...

nevermind it did, it just thinks that the dockerfile wasn't edited...ugh

(but also need to change the triggers for the other workflows. some bugs there)

fixed, edited the dockerfile with an empty commit to trigger the deploy preview

github-actions[bot] commented 10 months ago

Hello! I've built a preview of your PR so that you can compare it to the current main branch.