search

UBC-DSCI / introduction-to-datascience

Open Source Textbook for DSCI100: Introduction to Data Science in R
https://datasciencebook.ca/
Other
50 stars 55 forks source link

Copyediting round 2 #423

Closed trevorcampbell closed 2 years ago

trevorcampbell commented 2 years ago

This PR closes:

Note 0: the edits should be self-explanatory except one in reading.Rmd, where it looks like I just changed a few words for no reason. That was to force the "Stop! Are you allowed...." onto the next page.

Note 1: right now the container is at v0.22.0 on master (and dockerhub), which fixes the index hyperref issue. It's also v0.22.0 in the build scripts on this branch.

But because I originally edited the dockerfile on this branch (before I realized I had to do it on master), I eventually made the same edit directly on master and merged into this branch. So I suspect when we merge this PR into dev and then master, it might bump the docker container again. In that case you're safe to edit build_pdf.sh and build_html.sh to use container v0.23.0 -- nothing will change between v0.22.0 and v0.23.0.

Note 2: The docker image would not build unless I specified an updated version of the cancensus package (which canlang depends on). I had to pin cancensus to a git commit hash. So please double-check that nothing broke anywhere we use canlang.

Note 3: I was unable to get a single blank page between the dedications and the TOC. I could only get either 2 or 0. I believe LaTeX forces 2 blank pages here because the TOC has to start on an odd page. We should notify Michele of this, but I don't think we need to do anything ourselves

Note 4: You'll notice in the Exercises blurbs that I point to https://github.com/UBC-DSCI/data-science-a-first-intro-worksheets#readme (instead of https://ubc-dsci.github.io/data-science-a-first-intro-worksheets/ ). The "view worksheets" links don't work on the github.io site; they download the worksheet instead of previewing it in github. I also fixed the link and blurb text at the end of the preface where we mention worksheets.

Note 5: We should also tell Michele directly that Fig 1.7 and 1.8 are meant to have broken x axis labels (in addition to me editing the caption), because that was also flagged in the first copyediting pass.

leem44 commented 2 years ago

@trevorcampbell Thank you for making these changes! It looks good to me!