search

UBC-DSCI / introduction-to-datascience

Open Source Textbook for DSCI100: Introduction to Data Science in R
https://datasciencebook.ca/
Other
50 stars 54 forks source link

Ch1 4 #435

Closed ttimbers closed 2 years ago

ttimbers commented 2 years ago

Pull request for proof edits for chapters 1-4. Work in progress (chapters 1 & 2) are done except for this issue for chapter 2:

warning line should come before the Note... but it's not for some reason... (page 33 of book, source is in reading.Rmd)

Screen Shot 2022-05-04 at 8 20 09 PM

(same issue is present in html version of book...)

Source:

Screen Shot 2022-05-04 at 8 21 28 PM

This appears to be a bookdown thing... because if instead I use the knit button (or rmarkdown::render) it does what you would expect:

Screen Shot 2022-05-04 at 8 30 37 PM
ttimbers commented 2 years ago

OK @trevorcampbell - I have now added all the edits I view as "essential" and "scoped" to the proof. I still however don't have a fix for the one I highlighted above... Otherwise this is ready for your review.

ttimbers commented 2 years ago

Unaddressed issue at top of thread opened here: https://github.com/UBC-DSCI/introduction-to-datascience/issues/436