UBC-DSCI / introduction-to-datascience

Open Source Textbook for DSCI100: Introduction to Data Science in R
https://datasciencebook.ca/
Other
50 stars 54 forks source link

Book contents depend on non-static website (wikipedia) #450

Closed trevorcampbell closed 1 year ago

trevorcampbell commented 1 year ago

I just tried to rebuild after merging a minor change in viz, and I'm now seeing in the optional reading section

the nodes using the html_text function. In the case of the example node above, html_text function returns "London".

population_text <- html_text(population_nodes)
head(population_text)
## [1] "11"          "Ontario"     "12"          "Nova Scotia" "13"         
## [6] "Ontario"

which no longer makes any sense -- the actual book returns actual population values

population_text <- html_text(population_nodes)
head(population_text)
## [1] "London"                 "543,551\n"              "Halifax"               
## [4] "465,703\n"              "St. Catharines–Niagara" "433,604\n"

We need to go through and replace all non-static resources with static copies of their output, and avoid re-running the code

trevorcampbell commented 1 year ago

By the way once we fix this we should rebuild the book again (to incorporate the fix in #448 )

trevorcampbell commented 1 year ago

I think this should have been closed by #452, but need double-check this

trevorcampbell commented 1 year ago

Yep, it's handled now. Closing.