search

UBC-DSCI / introduction-to-datascience

Open Source Textbook for DSCI100: Introduction to Data Science in R
https://datasciencebook.ca/
Other
50 stars 54 forks source link

Different train/test split in Reg1 and Reg2 #475

Closed trevorcampbell closed 1 year ago

trevorcampbell commented 1 year ago

This causes the RMSE in the KNN vs Linear comparison in reg 2 to not line up properly (in the python version -- we may have gotten lucky in the R version).

Also the split proportion in Reg 1 is 0.75, in Reg 2 is 0.6...

Check this for classification 1 and 2 too, in case it matters.

trevorcampbell commented 1 year ago

It's fine in the R book. The python book has its issue open still, because it is an issue there.