The figures look so much better! Much cleaner and more consistent! Thank you for making those changes! One general comment about the figures: the figures look so much nicer, but sometimes the message of the figure is not as clear compared to the old version. I really like the new cleaner look, but just want to make sure we have the cleaner look without losing figure interpretability.
More specific comments below:
Figure 3.2 is a little confusing. It looks like one big table with "Vector" as the column headers and then "region", "year" and "population" as a highlighted row. I think it's because the use of the blue highlighting for that table is "highlighting" each column, but because there is no other colour in that table to contrast with it just looks like the whole table is blue. If I compare it to Fig. 3.1 then I get it, though each Figure should be interpretable as a stand-alone figure. Perhaps there is another way to display this Figure (and we may need to change other ones too for consistency...)
Fig 3.3, 3.4, 3.5. Similar comment as above
Section 3.3.2: "For example, to create the vector region as shown in Figure 3.3, you would write: year <- c("Toronto", "Montreal", "Vancouver", "Calgary", "Ottawa")"
Change "year" to "region" in the R code. Also the order of the regions of the R object doesn't match the picture in Fig 3.3, so we should change that so they are consistent. Picture shows "Toronto, Vancouver, Montreal, Calgary, Ottawa", so we should change the code to be consistent with pic
Section 3.3.4: The Note says "_If the data object is a tibble it will return "tbl_df" "tbl" "data.frame"._ ", however we get something slightly different: "spec_tbl_df" "tbl_df" "tbl" "data.frame". We should change to make it match
Figure 3.6: This figure looks really good! But it's too subtle. Particularly the rows = observations and columns = variables tables. I wonder if there is a way to get the message across more strongly. E.g. for the first table using a darker colour orange around each row and then the vertical orange line could be a little lighter (or whatever the designer thinks is best)
Figure 3.8 and 3.11: I think we should add something to indicate there are more rows in the tables (perhaps 3 dots under each column in the table?).
Figure 3.10 values in the "type" column ("Population", "Commuters", "Incorporated") in the left table are uppercase but the column names in the table on the right are lowercase. Since the values will become the names of the columns in the new table they should both be match
Section 3.7.2 The new column most_at_home_proportion gets cut off in the output of english_langs. Since in this section we are showing how to add new columns using mutate, perhaps we should modify this somehow so it doesn't cut this column name off. (maybe change the column name to something shorter? we'd have to check if it has downstream repercussions)
Figure 3.16: the caption needs to be changed to match the new colours in the table
Figure 3.18: its unclear what this Figure is depicting. I think it's too subtle. Perhaps this one and Figure 3.15 - 3.19 could be improved by adding some values to the tables
Figure 3.19 is too subtle and it's not clear what this is trying to depict
The figures look so much better! Much cleaner and more consistent! Thank you for making those changes! One general comment about the figures: the figures look so much nicer, but sometimes the message of the figure is not as clear compared to the old version. I really like the new cleaner look, but just want to make sure we have the cleaner look without losing figure interpretability.
More specific comments below:
regionas shown in Figure 3.3, you would write:year <- c("Toronto", "Montreal", "Vancouver", "Calgary", "Ottawa")" Change "year" to "region" in the R code. Also the order of the regions of the R object doesn't match the picture in Fig 3.3, so we should change that so they are consistent. Picture shows "Toronto, Vancouver, Montreal, Calgary, Ottawa", so we should change the code to be consistent with pic"tbl_df" "tbl" "data.frame"._ ", however we get something slightly different:"spec_tbl_df" "tbl_df" "tbl" "data.frame". We should change to make it matchmost_at_home_proportiongets cut off in the output ofenglish_langs. Since in this section we are showing how to add new columns using mutate, perhaps we should modify this somehow so it doesn't cut this column name off. (maybe change the column name to something shorter? we'd have to check if it has downstream repercussions)