UBC-ECE-Sasha / PIM-Embedding-Lookup

6 stars 5 forks source link

I can't find this file #17

Open jnider opened 3 years ago

jnider commented 3 years ago

https://github.com/UBC-ECE-Sasha/PIM-Embedding-Lookup/blob/8c96b122613f6a48780edec26bffa366c256e65b/upmem/Makefile#L39

I don't understand how your code works. I can't find where the main() function is on the host. Where does it all start from?

johnramsden commented 3 years ago

That was actually just a stub, the way he is actually we're going to add tests. It could also potentially be removed.

We run the code as described in upmem/README.md

https://github.com/UBC-ECE-Sasha/PIM-Embedding-Lookup/blob/8c96b122613f6a48780edec26bffa366c256e65b/upmem/run.sh#L56-L69

https://github.com/UBC-ECE-Sasha/PIM-Embedding-Lookup/blob/8c96b122613f6a48780edec26bffa366c256e65b/upmem/run.sh#L71-L83

https://github.com/UBC-ECE-Sasha/PIM-Embedding-Lookup/blob/8c96b122613f6a48780edec26bffa366c256e65b/upmem/run.sh#L85-L87