UBC-ECE-Sasha / PIM-Embedding-Lookup

6 stars 5 forks source link

32 should have a name #18

Open jnider opened 3 years ago

jnider commented 3 years ago

https://github.com/UBC-ECE-Sasha/PIM-Embedding-Lookup/blob/8c96b122613f6a48780edec26bffa366c256e65b/upmem/src/dpu/emb_dpu_lookup.c#L16

I see you used '32' a couple of times, but it's not clear to me what it represents. Is this the number of DPUs? In any case, it will be easier for everyone if this has a symbolic name.